Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly append LodestarError metadata in logs #6086

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: correctly append LodestarError metadata in logs #6086

merged 1 commit into from
Nov 6, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Nov 5, 2023

Motivation

Consistent log formatting

Description

LodestarError is formatted in the same way as context, it is either appended to the log message (" ") or extends existing context properties (", "). For any other error, the message is printed out and clearly separated from the log message (" - ").

See test cases for log examples

@nflaig nflaig requested a review from a team as a code owner November 5, 2023 16:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 692578d Previous: bf5d92b Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 850.76 us/op 701.36 us/op 1.21
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 49.878 us/op 80.286 us/op 0.62
BLS verify - blst-native 1.0517 ms/op 1.2322 ms/op 0.85
BLS verifyMultipleSignatures 3 - blst-native 2.2477 ms/op 2.5830 ms/op 0.87
BLS verifyMultipleSignatures 8 - blst-native 4.9688 ms/op 5.6807 ms/op 0.87
BLS verifyMultipleSignatures 32 - blst-native 18.240 ms/op 20.763 ms/op 0.88
BLS verifyMultipleSignatures 64 - blst-native 35.950 ms/op 40.970 ms/op 0.88
BLS verifyMultipleSignatures 128 - blst-native 71.373 ms/op 81.158 ms/op 0.88
BLS deserializing 10000 signatures 776.92 ms/op 868.40 ms/op 0.89
BLS deserializing 100000 signatures 7.8168 s/op 8.7169 s/op 0.90
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.1319 ms/op 1.2818 ms/op 0.88
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.2285 ms/op 1.4460 ms/op 0.85
BLS verifyMultipleSignatures - same message - 32 - blst-native 1.9294 ms/op 2.1727 ms/op 0.89
BLS verifyMultipleSignatures - same message - 64 - blst-native 2.8734 ms/op 3.3920 ms/op 0.85
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.1607 ms/op 5.5322 ms/op 1.11
BLS aggregatePubkeys 32 - blst-native 23.545 us/op 25.175 us/op 0.94
BLS aggregatePubkeys 128 - blst-native 88.868 us/op 99.488 us/op 0.89
getAttestationsForBlock 31.621 ms/op 36.889 ms/op 0.86
isKnown best case - 1 super set check 324.00 ns/op 282.00 ns/op 1.15
isKnown normal case - 2 super set checks 331.00 ns/op 285.00 ns/op 1.16
isKnown worse case - 16 super set checks 322.00 ns/op 283.00 ns/op 1.14
CheckpointStateCache - add get delete 3.7930 us/op 5.2360 us/op 0.72
validate api signedAggregateAndProof - struct 2.2884 ms/op 2.6872 ms/op 0.85
validate gossip signedAggregateAndProof - struct 2.3014 ms/op 2.6182 ms/op 0.88
validate gossip attestation - vc 640000 1.1395 ms/op 1.2874 ms/op 0.89
batch validate gossip attestation - vc 640000 - chunk 32 135.13 us/op 151.91 us/op 0.89
batch validate gossip attestation - vc 640000 - chunk 64 118.77 us/op 134.33 us/op 0.88
batch validate gossip attestation - vc 640000 - chunk 128 110.52 us/op 126.02 us/op 0.88
batch validate gossip attestation - vc 640000 - chunk 256 106.25 us/op 123.84 us/op 0.86
pickEth1Vote - no votes 882.00 us/op 1.1562 ms/op 0.76
pickEth1Vote - max votes 9.5970 ms/op 9.1247 ms/op 1.05
pickEth1Vote - Eth1Data hashTreeRoot value x2048 19.180 ms/op 19.156 ms/op 1.00
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 25.259 ms/op 27.719 ms/op 0.91
pickEth1Vote - Eth1Data fastSerialize value x2048 369.11 us/op 570.60 us/op 0.65
pickEth1Vote - Eth1Data fastSerialize tree x2048 8.2948 ms/op 7.3430 ms/op 1.13
bytes32 toHexString 407.00 ns/op 474.00 ns/op 0.86
bytes32 Buffer.toString(hex) 285.00 ns/op 280.00 ns/op 1.02
bytes32 Buffer.toString(hex) from Uint8Array 412.00 ns/op 404.00 ns/op 1.02
bytes32 Buffer.toString(hex) + 0x 285.00 ns/op 272.00 ns/op 1.05
Object access 1 prop 0.18900 ns/op 0.15600 ns/op 1.21
Map access 1 prop 0.17800 ns/op 0.14700 ns/op 1.21
Object get x1000 4.7380 ns/op 6.8620 ns/op 0.69
Map get x1000 0.49400 ns/op 0.58800 ns/op 0.84
Object set x1000 23.826 ns/op 46.841 ns/op 0.51
Map set x1000 16.575 ns/op 35.855 ns/op 0.46
Return object 10000 times 0.21090 ns/op 0.22370 ns/op 0.94
Throw Error 10000 times 2.5543 us/op 3.6976 us/op 0.69
fastMsgIdFn sha256 / 200 bytes 1.8660 us/op 3.2150 us/op 0.58
fastMsgIdFn h32 xxhash / 200 bytes 283.00 ns/op 266.00 ns/op 1.06
fastMsgIdFn h64 xxhash / 200 bytes 336.00 ns/op 326.00 ns/op 1.03
fastMsgIdFn sha256 / 1000 bytes 5.6720 us/op 11.026 us/op 0.51
fastMsgIdFn h32 xxhash / 1000 bytes 405.00 ns/op 377.00 ns/op 1.07
fastMsgIdFn h64 xxhash / 1000 bytes 397.00 ns/op 382.00 ns/op 1.04
fastMsgIdFn sha256 / 10000 bytes 48.974 us/op 97.725 us/op 0.50
fastMsgIdFn h32 xxhash / 10000 bytes 1.6980 us/op 1.8040 us/op 0.94
fastMsgIdFn h64 xxhash / 10000 bytes 1.1660 us/op 1.2430 us/op 0.94
send data - 1000 256B messages 11.324 ms/op 18.134 ms/op 0.62
send data - 1000 512B messages 15.293 ms/op 25.151 ms/op 0.61
send data - 1000 1024B messages 22.339 ms/op 39.378 ms/op 0.57
send data - 1000 1200B messages 26.729 ms/op 33.764 ms/op 0.79
send data - 1000 2048B messages 30.895 ms/op 39.404 ms/op 0.78
send data - 1000 4096B messages 29.993 ms/op 38.715 ms/op 0.77
send data - 1000 16384B messages 74.138 ms/op 102.73 ms/op 0.72
send data - 1000 65536B messages 317.56 ms/op 419.04 ms/op 0.76
enrSubnets - fastDeserialize 64 bits 968.00 ns/op 1.2560 us/op 0.77
enrSubnets - ssz BitVector 64 bits 436.00 ns/op 410.00 ns/op 1.06
enrSubnets - fastDeserialize 4 bits 196.00 ns/op 163.00 ns/op 1.20
enrSubnets - ssz BitVector 4 bits 439.00 ns/op 418.00 ns/op 1.05
prioritizePeers score -10:0 att 32-0.1 sync 2-0 68.920 us/op 97.077 us/op 0.71
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 82.829 us/op 119.57 us/op 0.69
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 108.56 us/op 155.95 us/op 0.70
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 179.33 us/op 279.50 us/op 0.64
prioritizePeers score 0:0 att 64-1 sync 4-1 202.77 us/op 329.64 us/op 0.62
array of 16000 items push then shift 1.2999 us/op 1.5440 us/op 0.84
LinkedList of 16000 items push then shift 5.9210 ns/op 8.6390 ns/op 0.69
array of 16000 items push then pop 61.519 ns/op 72.403 ns/op 0.85
LinkedList of 16000 items push then pop 5.7200 ns/op 8.3870 ns/op 0.68
array of 24000 items push then shift 1.9100 us/op 2.3144 us/op 0.83
LinkedList of 24000 items push then shift 6.2310 ns/op 8.6170 ns/op 0.72
array of 24000 items push then pop 90.115 ns/op 84.190 ns/op 1.07
LinkedList of 24000 items push then pop 5.7540 ns/op 8.2060 ns/op 0.70
intersect bitArray bitLen 8 5.5800 ns/op 6.4820 ns/op 0.86
intersect array and set length 8 44.769 ns/op 56.632 ns/op 0.79
intersect bitArray bitLen 128 25.949 ns/op 32.038 ns/op 0.81
intersect array and set length 128 586.33 ns/op 768.15 ns/op 0.76
bitArray.getTrueBitIndexes() bitLen 128 1.1360 us/op 1.3730 us/op 0.83
bitArray.getTrueBitIndexes() bitLen 248 1.9170 us/op 2.3210 us/op 0.83
bitArray.getTrueBitIndexes() bitLen 512 3.4890 us/op 4.6730 us/op 0.75
Buffer.concat 32 items 843.00 ns/op 909.00 ns/op 0.93
Uint8Array.set 32 items 1.7720 us/op 1.7220 us/op 1.03
Set add up to 64 items then delete first 1.7299 us/op 4.2716 us/op 0.40
OrderedSet add up to 64 items then delete first 2.6694 us/op 5.3648 us/op 0.50
Set add up to 64 items then delete last 1.8921 us/op 4.3679 us/op 0.43
OrderedSet add up to 64 items then delete last 2.9597 us/op 5.4972 us/op 0.54
Set add up to 64 items then delete middle 1.9860 us/op 4.3594 us/op 0.46
OrderedSet add up to 64 items then delete middle 4.1873 us/op 6.9739 us/op 0.60
Set add up to 128 items then delete first 3.9207 us/op 9.2730 us/op 0.42
OrderedSet add up to 128 items then delete first 6.1738 us/op 12.139 us/op 0.51
Set add up to 128 items then delete last 3.7904 us/op 9.0417 us/op 0.42
OrderedSet add up to 128 items then delete last 5.6899 us/op 11.006 us/op 0.52
Set add up to 128 items then delete middle 3.7794 us/op 8.5728 us/op 0.44
OrderedSet add up to 128 items then delete middle 10.632 us/op 15.966 us/op 0.67
Set add up to 256 items then delete first 7.6888 us/op 17.827 us/op 0.43
OrderedSet add up to 256 items then delete first 12.190 us/op 23.649 us/op 0.52
Set add up to 256 items then delete last 7.4510 us/op 17.092 us/op 0.44
OrderedSet add up to 256 items then delete last 11.306 us/op 22.028 us/op 0.51
Set add up to 256 items then delete middle 7.4134 us/op 17.076 us/op 0.43
OrderedSet add up to 256 items then delete middle 30.686 us/op 42.523 us/op 0.72
transfer serialized Status (84 B) 1.5620 us/op 1.7680 us/op 0.88
copy serialized Status (84 B) 1.3480 us/op 1.4560 us/op 0.93
transfer serialized SignedVoluntaryExit (112 B) 1.7720 us/op 1.8720 us/op 0.95
copy serialized SignedVoluntaryExit (112 B) 1.4150 us/op 1.4980 us/op 0.94
transfer serialized ProposerSlashing (416 B) 2.1650 us/op 2.2550 us/op 0.96
copy serialized ProposerSlashing (416 B) 2.3220 us/op 2.1450 us/op 1.08
transfer serialized Attestation (485 B) 2.5340 us/op 2.4510 us/op 1.03
copy serialized Attestation (485 B) 2.5980 us/op 2.0050 us/op 1.30
transfer serialized AttesterSlashing (33232 B) 2.7100 us/op 2.2590 us/op 1.20
copy serialized AttesterSlashing (33232 B) 4.7770 us/op 5.1590 us/op 0.93
transfer serialized Small SignedBeaconBlock (128000 B) 2.4360 us/op 2.6970 us/op 0.90
copy serialized Small SignedBeaconBlock (128000 B) 9.1860 us/op 13.062 us/op 0.70
transfer serialized Avg SignedBeaconBlock (200000 B) 2.8880 us/op 2.9760 us/op 0.97
copy serialized Avg SignedBeaconBlock (200000 B) 12.865 us/op 19.519 us/op 0.66
transfer serialized BlobsSidecar (524380 B) 2.6300 us/op 2.7230 us/op 0.97
copy serialized BlobsSidecar (524380 B) 70.790 us/op 107.31 us/op 0.66
transfer serialized Big SignedBeaconBlock (1000000 B) 2.9030 us/op 2.8150 us/op 1.03
copy serialized Big SignedBeaconBlock (1000000 B) 128.75 us/op 163.72 us/op 0.79
pass gossip attestations to forkchoice per slot 2.6520 ms/op 3.8450 ms/op 0.69
forkChoice updateHead vc 100000 bc 64 eq 0 458.21 us/op 643.87 us/op 0.71
forkChoice updateHead vc 600000 bc 64 eq 0 2.9514 ms/op 4.7433 ms/op 0.62
forkChoice updateHead vc 1000000 bc 64 eq 0 4.3898 ms/op 6.9777 ms/op 0.63
forkChoice updateHead vc 600000 bc 320 eq 0 2.6561 ms/op 4.1634 ms/op 0.64
forkChoice updateHead vc 600000 bc 1200 eq 0 2.7331 ms/op 4.2540 ms/op 0.64
forkChoice updateHead vc 600000 bc 7200 eq 0 3.5192 ms/op 5.1942 ms/op 0.68
forkChoice updateHead vc 600000 bc 64 eq 1000 9.9331 ms/op 10.719 ms/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 10000 9.7646 ms/op 11.476 ms/op 0.85
forkChoice updateHead vc 600000 bc 64 eq 300000 11.846 ms/op 14.859 ms/op 0.80
computeDeltas 500000 validators 300 proto nodes 2.9145 ms/op 6.3667 ms/op 0.46
computeDeltas 500000 validators 1200 proto nodes 2.8850 ms/op 6.2456 ms/op 0.46
computeDeltas 500000 validators 7200 proto nodes 2.9077 ms/op 6.2328 ms/op 0.47
computeDeltas 750000 validators 300 proto nodes 4.3845 ms/op 9.4025 ms/op 0.47
computeDeltas 750000 validators 1200 proto nodes 4.3949 ms/op 9.4312 ms/op 0.47
computeDeltas 750000 validators 7200 proto nodes 4.4216 ms/op 9.5124 ms/op 0.46
computeDeltas 1400000 validators 300 proto nodes 8.6502 ms/op 18.257 ms/op 0.47
computeDeltas 1400000 validators 1200 proto nodes 8.9805 ms/op 17.848 ms/op 0.50
computeDeltas 1400000 validators 7200 proto nodes 8.5617 ms/op 18.506 ms/op 0.46
computeDeltas 2100000 validators 300 proto nodes 13.635 ms/op 27.561 ms/op 0.49
computeDeltas 2100000 validators 1200 proto nodes 13.916 ms/op 27.106 ms/op 0.51
computeDeltas 2100000 validators 7200 proto nodes 13.512 ms/op 27.950 ms/op 0.48
computeProposerBoostScoreFromBalances 500000 validators 2.6377 ms/op 3.1470 ms/op 0.84
computeProposerBoostScoreFromBalances 750000 validators 2.6716 ms/op 3.0888 ms/op 0.86
computeProposerBoostScoreFromBalances 1400000 validators 2.6461 ms/op 3.0773 ms/op 0.86
computeProposerBoostScoreFromBalances 2100000 validators 2.7785 ms/op 3.0794 ms/op 0.90
altair processAttestation - 250000 vs - 7PWei normalcase 1.3422 ms/op 2.1914 ms/op 0.61
altair processAttestation - 250000 vs - 7PWei worstcase 2.2353 ms/op 3.1965 ms/op 0.70
altair processAttestation - setStatus - 1/6 committees join 76.646 us/op 174.32 us/op 0.44
altair processAttestation - setStatus - 1/3 committees join 151.28 us/op 341.16 us/op 0.44
altair processAttestation - setStatus - 1/2 committees join 225.07 us/op 463.92 us/op 0.49
altair processAttestation - setStatus - 2/3 committees join 273.99 us/op 568.27 us/op 0.48
altair processAttestation - setStatus - 4/5 committees join 382.85 us/op 775.11 us/op 0.49
altair processAttestation - setStatus - 100% committees join 483.15 us/op 899.52 us/op 0.54
altair processBlock - 250000 vs - 7PWei normalcase 8.2794 ms/op 10.194 ms/op 0.81
altair processBlock - 250000 vs - 7PWei normalcase hashState 31.220 ms/op 34.000 ms/op 0.92
altair processBlock - 250000 vs - 7PWei worstcase 32.181 ms/op 39.279 ms/op 0.82
altair processBlock - 250000 vs - 7PWei worstcase hashState 81.977 ms/op 97.019 ms/op 0.84
phase0 processBlock - 250000 vs - 7PWei normalcase 2.1745 ms/op 2.4797 ms/op 0.88
phase0 processBlock - 250000 vs - 7PWei worstcase 26.119 ms/op 29.608 ms/op 0.88
altair processEth1Data - 250000 vs - 7PWei normalcase 287.50 us/op 558.13 us/op 0.52
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 3.5110 us/op 10.385 us/op 0.34
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 57.186 us/op 65.119 us/op 0.88
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 19.696 us/op 22.023 us/op 0.89
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 5.9600 us/op 12.649 us/op 0.47
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 151.60 us/op 158.72 us/op 0.96
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0878 ms/op 1.0326 ms/op 1.05
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.3400 ms/op 1.6999 ms/op 0.79
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 898.68 us/op 1.4585 ms/op 0.62
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.1207 ms/op 3.5103 ms/op 0.60
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.5071 ms/op 2.3154 ms/op 0.65
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.9787 ms/op 4.7735 ms/op 0.83
Tree 40 250000 create 264.37 ms/op 341.26 ms/op 0.77
Tree 40 250000 get(125000) 110.75 ns/op 196.34 ns/op 0.56
Tree 40 250000 set(125000) 717.96 ns/op 989.98 ns/op 0.73
Tree 40 250000 toArray() 10.506 ms/op 17.852 ms/op 0.59
Tree 40 250000 iterate all - toArray() + loop 9.6769 ms/op 17.919 ms/op 0.54
Tree 40 250000 iterate all - get(i) 37.968 ms/op 66.387 ms/op 0.57
MutableVector 250000 create 10.769 ms/op 11.557 ms/op 0.93
MutableVector 250000 get(125000) 5.5710 ns/op 7.0830 ns/op 0.79
MutableVector 250000 set(125000) 188.67 ns/op 251.20 ns/op 0.75
MutableVector 250000 toArray() 2.2008 ms/op 3.1838 ms/op 0.69
MutableVector 250000 iterate all - toArray() + loop 2.5576 ms/op 3.2809 ms/op 0.78
MutableVector 250000 iterate all - get(i) 1.2914 ms/op 1.5343 ms/op 0.84
Array 250000 create 2.3579 ms/op 2.8731 ms/op 0.82
Array 250000 clone - spread 1.0169 ms/op 1.2399 ms/op 0.82
Array 250000 get(125000) 0.57700 ns/op 0.58100 ns/op 0.99
Array 250000 set(125000) 0.64400 ns/op 0.65400 ns/op 0.98
Array 250000 iterate all - loop 73.018 us/op 81.786 us/op 0.89
effectiveBalanceIncrements clone Uint8Array 300000 18.035 us/op 24.667 us/op 0.73
effectiveBalanceIncrements clone MutableVector 300000 370.00 ns/op 355.00 ns/op 1.04
effectiveBalanceIncrements rw all Uint8Array 300000 160.40 us/op 177.14 us/op 0.91
effectiveBalanceIncrements rw all MutableVector 300000 61.601 ms/op 80.517 ms/op 0.77
phase0 afterProcessEpoch - 250000 vs - 7PWei 72.703 ms/op 113.10 ms/op 0.64
phase0 beforeProcessEpoch - 250000 vs - 7PWei 38.842 ms/op 48.268 ms/op 0.80
altair processEpoch - mainnet_e81889 424.52 ms/op 456.83 ms/op 0.93
mainnet_e81889 - altair beforeProcessEpoch 69.947 ms/op 74.884 ms/op 0.93
mainnet_e81889 - altair processJustificationAndFinalization 9.1260 us/op 14.859 us/op 0.61
mainnet_e81889 - altair processInactivityUpdates 3.5198 ms/op 5.5104 ms/op 0.64
mainnet_e81889 - altair processRewardsAndPenalties 73.526 ms/op 70.022 ms/op 1.05
mainnet_e81889 - altair processRegistryUpdates 1.1520 us/op 2.7310 us/op 0.42
mainnet_e81889 - altair processSlashings 481.00 ns/op 435.00 ns/op 1.11
mainnet_e81889 - altair processEth1DataReset 498.00 ns/op 665.00 ns/op 0.75
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.5619 ms/op 1.2549 ms/op 1.24
mainnet_e81889 - altair processSlashingsReset 1.7690 us/op 3.4010 us/op 0.52
mainnet_e81889 - altair processRandaoMixesReset 3.5710 us/op 4.2190 us/op 0.85
mainnet_e81889 - altair processHistoricalRootsUpdate 685.00 ns/op 831.00 ns/op 0.82
mainnet_e81889 - altair processParticipationFlagUpdates 1.4130 us/op 2.1830 us/op 0.65
mainnet_e81889 - altair processSyncCommitteeUpdates 564.00 ns/op 586.00 ns/op 0.96
mainnet_e81889 - altair afterProcessEpoch 80.455 ms/op 113.04 ms/op 0.71
capella processEpoch - mainnet_e217614 1.7318 s/op 1.9247 s/op 0.90
mainnet_e217614 - capella beforeProcessEpoch 371.90 ms/op 445.70 ms/op 0.83
mainnet_e217614 - capella processJustificationAndFinalization 9.8140 us/op 13.028 us/op 0.75
mainnet_e217614 - capella processInactivityUpdates 17.968 ms/op 17.147 ms/op 1.05
mainnet_e217614 - capella processRewardsAndPenalties 441.69 ms/op 499.05 ms/op 0.89
mainnet_e217614 - capella processRegistryUpdates 7.2760 us/op 25.554 us/op 0.28
mainnet_e217614 - capella processSlashings 306.00 ns/op 541.00 ns/op 0.57
mainnet_e217614 - capella processEth1DataReset 289.00 ns/op 438.00 ns/op 0.66
mainnet_e217614 - capella processEffectiveBalanceUpdates 3.1587 ms/op 3.9318 ms/op 0.80
mainnet_e217614 - capella processSlashingsReset 984.00 ns/op 3.1730 us/op 0.31
mainnet_e217614 - capella processRandaoMixesReset 1.6050 us/op 5.4910 us/op 0.29
mainnet_e217614 - capella processHistoricalRootsUpdate 308.00 ns/op 742.00 ns/op 0.42
mainnet_e217614 - capella processParticipationFlagUpdates 1.0230 us/op 2.2190 us/op 0.46
mainnet_e217614 - capella afterProcessEpoch 195.31 ms/op 315.22 ms/op 0.62
phase0 processEpoch - mainnet_e58758 391.85 ms/op 407.98 ms/op 0.96
mainnet_e58758 - phase0 beforeProcessEpoch 108.16 ms/op 122.67 ms/op 0.88
mainnet_e58758 - phase0 processJustificationAndFinalization 10.804 us/op 14.968 us/op 0.72
mainnet_e58758 - phase0 processRewardsAndPenalties 51.063 ms/op 45.083 ms/op 1.13
mainnet_e58758 - phase0 processRegistryUpdates 7.1970 us/op 9.9880 us/op 0.72
mainnet_e58758 - phase0 processSlashings 360.00 ns/op 535.00 ns/op 0.67
mainnet_e58758 - phase0 processEth1DataReset 555.00 ns/op 472.00 ns/op 1.18
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.2204 ms/op 942.13 us/op 1.30
mainnet_e58758 - phase0 processSlashingsReset 4.3650 us/op 2.1390 us/op 2.04
mainnet_e58758 - phase0 processRandaoMixesReset 2.7650 us/op 4.0670 us/op 0.68
mainnet_e58758 - phase0 processHistoricalRootsUpdate 764.00 ns/op 572.00 ns/op 1.34
mainnet_e58758 - phase0 processParticipationRecordUpdates 2.8650 us/op 3.3550 us/op 0.85
mainnet_e58758 - phase0 afterProcessEpoch 62.479 ms/op 95.302 ms/op 0.66
phase0 processEffectiveBalanceUpdates - 250000 normalcase 881.07 us/op 1.1954 ms/op 0.74
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.8071 ms/op 1.3997 ms/op 1.29
altair processInactivityUpdates - 250000 normalcase 19.216 ms/op 18.381 ms/op 1.05
altair processInactivityUpdates - 250000 worstcase 16.426 ms/op 21.206 ms/op 0.77
phase0 processRegistryUpdates - 250000 normalcase 3.4980 us/op 7.5020 us/op 0.47
phase0 processRegistryUpdates - 250000 badcase_full_deposits 380.20 us/op 334.33 us/op 1.14
phase0 processRegistryUpdates - 250000 worstcase 0.5 110.41 ms/op 117.58 ms/op 0.94
altair processRewardsAndPenalties - 250000 normalcase 69.922 ms/op 66.608 ms/op 1.05
altair processRewardsAndPenalties - 250000 worstcase 67.066 ms/op 64.104 ms/op 1.05
phase0 getAttestationDeltas - 250000 normalcase 4.9148 ms/op 7.9021 ms/op 0.62
phase0 getAttestationDeltas - 250000 worstcase 5.5681 ms/op 8.2897 ms/op 0.67
phase0 processSlashings - 250000 worstcase 1.5477 ms/op 2.2683 ms/op 0.68
altair processSyncCommitteeUpdates - 250000 105.50 ms/op 148.48 ms/op 0.71
BeaconState.hashTreeRoot - No change 304.00 ns/op 240.00 ns/op 1.27
BeaconState.hashTreeRoot - 1 full validator 146.42 us/op 128.29 us/op 1.14
BeaconState.hashTreeRoot - 32 full validator 1.4677 ms/op 1.5941 ms/op 0.92
BeaconState.hashTreeRoot - 512 full validator 16.288 ms/op 17.043 ms/op 0.96
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 166.36 us/op 169.10 us/op 0.98
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.9249 ms/op 2.3222 ms/op 0.83
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 24.881 ms/op 27.362 ms/op 0.91
BeaconState.hashTreeRoot - 1 balances 140.62 us/op 132.15 us/op 1.06
BeaconState.hashTreeRoot - 32 balances 1.0656 ms/op 1.0980 ms/op 0.97
BeaconState.hashTreeRoot - 512 balances 10.485 ms/op 11.459 ms/op 0.92
BeaconState.hashTreeRoot - 250000 balances 190.57 ms/op 197.10 ms/op 0.97
aggregationBits - 2048 els - zipIndexesInBitList 9.8280 us/op 15.359 us/op 0.64
byteArrayEquals 32 48.098 ns/op 48.303 ns/op 1.00
Buffer.compare 32 37.910 ns/op 53.510 ns/op 0.71
byteArrayEquals 1024 1.2741 us/op 1.4037 us/op 0.91
Buffer.compare 1024 47.389 ns/op 67.248 ns/op 0.70
byteArrayEquals 16384 20.320 us/op 22.318 us/op 0.91
Buffer.compare 16384 203.72 ns/op 265.66 ns/op 0.77
byteArrayEquals 123687377 149.39 ms/op 169.65 ms/op 0.88
Buffer.compare 123687377 5.5789 ms/op 6.0079 ms/op 0.93
byteArrayEquals 32 - diff last byte 40.190 ns/op 46.982 ns/op 0.86
Buffer.compare 32 - diff last byte 34.408 ns/op 54.430 ns/op 0.63
byteArrayEquals 1024 - diff last byte 1.1721 us/op 1.4229 us/op 0.82
Buffer.compare 1024 - diff last byte 41.175 ns/op 69.961 ns/op 0.59
byteArrayEquals 16384 - diff last byte 18.588 us/op 22.653 us/op 0.82
Buffer.compare 16384 - diff last byte 217.34 ns/op 248.72 ns/op 0.87
byteArrayEquals 123687377 - diff last byte 149.37 ms/op 168.74 ms/op 0.89
Buffer.compare 123687377 - diff last byte 4.7969 ms/op 5.9938 ms/op 0.80
byteArrayEquals 32 - random bytes 4.9790 ns/op 5.8670 ns/op 0.85
Buffer.compare 32 - random bytes 39.556 ns/op 59.107 ns/op 0.67
byteArrayEquals 1024 - random bytes 4.7620 ns/op 5.6110 ns/op 0.85
Buffer.compare 1024 - random bytes 39.264 ns/op 59.937 ns/op 0.66
byteArrayEquals 16384 - random bytes 4.7740 ns/op 5.7650 ns/op 0.83
Buffer.compare 16384 - random bytes 39.165 ns/op 57.437 ns/op 0.68
byteArrayEquals 123687377 - random bytes 8.2300 ns/op 8.7700 ns/op 0.94
Buffer.compare 123687377 - random bytes 42.550 ns/op 62.270 ns/op 0.68
regular array get 100000 times 31.709 us/op 32.697 us/op 0.97
wrappedArray get 100000 times 31.850 us/op 32.601 us/op 0.98
arrayWithProxy get 100000 times 10.418 ms/op 14.886 ms/op 0.70
ssz.Root.equals 50.292 ns/op 47.477 ns/op 1.06
byteArrayEquals 43.321 ns/op 46.665 ns/op 0.93
Buffer.compare 9.4920 ns/op 10.353 ns/op 0.92
shuffle list - 16384 els 5.1187 ms/op 6.7430 ms/op 0.76
shuffle list - 250000 els 72.364 ms/op 98.584 ms/op 0.73
processSlot - 1 slots 16.685 us/op 15.749 us/op 1.06
processSlot - 32 slots 3.8935 ms/op 3.2908 ms/op 1.18
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 54.492 ms/op 55.222 ms/op 0.99
getCommitteeAssignments - req 1 vs - 250000 vc 2.3337 ms/op 2.5210 ms/op 0.93
getCommitteeAssignments - req 100 vs - 250000 vc 3.5975 ms/op 3.7001 ms/op 0.97
getCommitteeAssignments - req 1000 vs - 250000 vc 3.8900 ms/op 4.0963 ms/op 0.95
findModifiedValidators - 10000 modified validators 553.37 ms/op 580.32 ms/op 0.95
findModifiedValidators - 1000 modified validators 364.51 ms/op 445.00 ms/op 0.82
findModifiedValidators - 100 modified validators 327.72 ms/op 421.19 ms/op 0.78
findModifiedValidators - 10 modified validators 370.90 ms/op 399.83 ms/op 0.93
findModifiedValidators - 1 modified validators 347.72 ms/op 397.89 ms/op 0.87
findModifiedValidators - no difference 351.30 ms/op 395.42 ms/op 0.89
compare ViewDUs 5.1462 s/op 4.2546 s/op 1.21
compare each validator Uint8Array 2.0655 s/op 1.7414 s/op 1.19
compare ViewDU to Uint8Array 1.1931 s/op 1.0943 s/op 1.09
migrate state 1000000 validators, 24 modified, 0 new 771.68 ms/op 697.29 ms/op 1.11
migrate state 1000000 validators, 1700 modified, 1000 new 913.10 ms/op 996.88 ms/op 0.92
migrate state 1000000 validators, 3400 modified, 2000 new 1.2552 s/op 1.1960 s/op 1.05
migrate state 1500000 validators, 24 modified, 0 new 746.09 ms/op 728.62 ms/op 1.02
migrate state 1500000 validators, 1700 modified, 1000 new 1.0061 s/op 1.0658 s/op 0.94
migrate state 1500000 validators, 3400 modified, 2000 new 1.1345 s/op 1.3235 s/op 0.86
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5500 ns/op 4.1500 ns/op 1.10
state getBlockRootAtSlot - 250000 vs - 7PWei 391.54 ns/op 745.46 ns/op 0.53
computeProposers - vc 250000 5.6594 ms/op 9.1147 ms/op 0.62
computeEpochShuffling - vc 250000 68.098 ms/op 104.02 ms/op 0.65
getNextSyncCommittee - vc 250000 97.834 ms/op 155.54 ms/op 0.63
computeSigningRoot for AttestationData 20.327 us/op 29.556 us/op 0.69
hash AttestationData serialized data then Buffer.toString(base64) 1.2493 us/op 2.2587 us/op 0.55
toHexString serialized data 805.93 ns/op 1.0275 us/op 0.78
Buffer.toString(base64) 147.96 ns/op 220.94 ns/op 0.67

by benchmarkbot/action

@nflaig nflaig force-pushed the nflaig/lodestar-error-log branch from 71ffb8f to 8e58b75 Compare November 5, 2023 19:06
@nflaig nflaig enabled auto-merge (squash) November 5, 2023 20:54
@nflaig nflaig merged commit d3f40d2 into unstable Nov 6, 2023
15 checks passed
@nflaig nflaig deleted the nflaig/lodestar-error-log branch November 6, 2023 04:06
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain